perf: Improve performance of to_hex (> 2x)
#19503
Merged
+207
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
to_hexto_hex by 2x
Dandandan
reviewed
Dec 26, 2025
| ); | ||
| } | ||
| result.append_value(""); | ||
| let hex_str = value.to_hex(&mut buffer); |
Contributor
There was a problem hiding this comment.
This could be made faster by handling the values separately from the nulls / avoiding the builder API.
Member
Author
There was a problem hiding this comment.
Thanks, it is even faster now! I updated the benchmark results in the PR description.
andygrove
changed the title
to_hex by 2xto_hex (> 2x)
Jefffrey
approved these changes
Dec 26, 2025
| // Start with offset 0 | ||
| offsets.push(0); | ||
|
|
||
| // Process all values directly (including null slots - we write empty strings for nulls) |
Contributor
There was a problem hiding this comment.
nit: I don't think this code is writing empty strings for nulls, it seems to process whatever value is in the null slot normally
Dandandan
approved these changes
Dec 27, 2025
Contributor
|
Thanks @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
What changes are included in this PR?
Avoid string allocations and re-use a mutable buffer.
Are these changes tested?
Are there any user-facing changes?