Skip to content

Conversation

@Jefffrey
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

See issue.

What changes are included in this PR?

Add new TypeSignatureClass variant Any and refactor arrow_typeof and arrow_metadata function signatures to use this.

Are these changes tested?

Existing tests.

Are there any user-facing changes?

No.

@github-actions github-actions bot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Dec 25, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 25, 2025
SELECT arrow_cast('1')

query error DataFusion error: Execution error: arrow_cast requires its second argument to be a non\-empty constant string
query error Expect TypeSignatureClass::Native\(LogicalType\(Native\(String\), String\)\) but received NativeType::Int64, DataType: Int64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should start looking in #19004 properly to try pretty up these new error messages 🤔

@Jefffrey Jefffrey marked this pull request as ready for review December 25, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding TypeSignatureClass::Any variant

1 participant