limit iso filename to have 251 chars at max

[sudo87]

Description

This PR proposes 251 char limit on iso filename to prevent this issue #11731

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.76%. Comparing base (8627c60) to head (1487220).
⚠️ Report is 5 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12430      +/-   ##
============================================
+ Coverage     16.24%   17.76%   +1.52%     
- Complexity    13378    15862    +2484     
============================================
  Files          5657     5923     +266     
  Lines        498971   530631   +31660     
  Branches      60561    64840    +4279     
============================================
+ Hits          81033    94253   +13220     
- Misses       408904   425831   +16927     
- Partials       9034    10547    +1513     

Flag	Coverage Δ
uitests	3.59% <ø> (-0.44%)	⬇️
unittests	18.84% <ø> (+1.75%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16380

[DaanHoogland]

clgtm

[vishesh92]

clgtm. IMO, it will be good to have this restriction in the UI as well.

[DaanHoogland]

@sudo87 , can you rebase on the 4.20 branch?

[sudo87]

my bad, it is meant for 4.20, corrected the base.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16394