Move ExpandDisjunctionForJoinInputsRule test from planner.iq to hep.iq #4715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiedeyantu
commented
Dec 31, 2025
| !plan | ||
|
|
||
| !set planner-rules " | ||
| +CoreRules.EXPAND_FILTER_DISJUNCTION_LOCAL" |
Member
Author
There was a problem hiding this comment.
Because the new disjoint algorithm performs FILTER_INTO_JOIN before and after execution, the EXPAND_FILTER_DISJUNCTION_LOCAL rule fails to take effect, leading to plan inconsistencies. Furthermore, EXPAND_JOIN_DISJUNCTION_LOCAL creates an infinite loop in the Volcano planner, making it unsuitable for planner.iq. Therefore, I moved it to hep.iq, allowing the Hep planner to perform the validation, which then executes the SQL correctly.
xiedeyantu
force-pushed
the
move-test
branch
from
83b9f32 to
bcd5ff0
Compare
Member
Author
|
Please review if you have time. @silundong |
xiedeyantu
force-pushed
the
move-test
branch
from
bcd5ff0 to
c36847f
Compare
|
xiedeyantu
added
the
LGTM-will-merge-soon
Member
Author
|
@silundong Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.