-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48782: [Docs][CI] Skip Markdown files with doxygen and trigger Docs job on PR when files are modified #48786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for raising the PR Raul! LGTM
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also #48795
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh didn't see this open first. LGTM! closing mine #48795!
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2805afd. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Docs jobs are currently failing with Doxygen failure due to parsing the
cpp/src/arrow/flight/sql/odbc/README.mdfile.What changes are included in this PR?
Minor fix to escape path and add Skip markdown files when running doxygen on doxygen config.
Add trigger for Complete docs workflow on Pull requests when documentation is modified.
Are these changes tested?
Yes locally.
Are there any user-facing changes?
No