GH-33459: [C++][Python] Support step >= 1 in list_slice kernel #48769
+58
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes ARROW-18281, which has been open since 2022. The
list_slicekernel currently rejectsstart == stop, but should return empty lists instead (following Python slicing semantics).The implementation already handles this case correctly. When ARROW-18282 added step support,
bit_util::CeilDiv(stop - start, step)naturally returns 0 forstart == stop, producing empty lists. The only issue was the validation check (start >= stop) that prevented this from working.What changes are included in this PR?
start >= stoptostart > stopAre these changes tested?
Yes, tests were added.
Are there any user-facing changes?
Yes.
Before:
After: