Remove old add = tests

[DavisVaughan]

Hi there, we are working on dplyr 1.2.0 and your package was flagged in our reverse dependency checks.

The add argument to group_by() is now defunct. You should use .add instead.

It looks like arrow was already doing this, it just had some outdated tests that relied on the old way.

You'll need to update your package to stay on CRAN.

We are still working on dplyr 1.2.0, but you can consider this an (at minimum) 2 week notice!

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[jonkeane]

Thanks for this! I need to double check we aren't using it anywhere else, but will merge once I do that.

[jonkeane]

This looks good, would you mind also removing add from the group_by signature as well? It's ok if you don't want to, but would be nice to have it cleaned up all at once IMHO

[DavisVaughan]

I just realized I was branched off a 2 year old main 😱 , that was the cause of the merge conflict

So I just rebased on current main to fix that and also removed add from your group_by() S3 methods

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4cc41f4.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.