fix(app): match terminal and review toggle button padding with sidebar toggle #9744
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r toggle Update the terminal and review toggle buttons in the session header to use size-8 rounded-md instead of size-6 to match the sidebar toggle styling in the titlebar. Fixes anomalyco#9713
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #9728 - "fix(ui): remove portal spacer and fix terminal toggle padding" Reason: This PR also addresses terminal toggle padding fixes, which directly overlaps with the current PR (#9744). Both are working on the same component and issue area. This should be reviewed to ensure there's no duplicate work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9713
Problem
The terminal toggle button (and review toggle button) in the session header use different padding/density than the sidebar toggle in the titlebar, resulting in inconsistent UI appearance.
Solution
Update the terminal and review toggle buttons from
size-6tosize-8 rounded-mdto match the sidebar toggle styling.Changes
class="group/review-toggle size-6 p-0"toclass="group/review-toggle size-8 rounded-md p-0"insession-header.tsxclass="group/terminal-toggle size-6 p-0"toclass="group/terminal-toggle size-8 rounded-md p-0"insession-header.tsxTesting
p-0padding override is preserved for the custom icon layout within the buttons