fix(app): terminal improvements - focus, rename, error state, CSP

[unitythemaker]

Summary

• Terminal focus fix - Keyboard input now goes to terminal instead of chat (focuses ghostty's internal textarea)
• Terminal rename - Double-click tab or right-click → Rename (with overlay input approach)
• Terminal error state - Shows dismissable "Connection Lost" message when connection fails
• CSP update - Added wasm-unsafe-eval to script-src and data: to connect-src for ghostty WASM
• OPENCODE_TERMINAL=1 env var - Added for PTY sessions to detect opencode terminal context
• Terminal navigation - Added next() and previous() methods to terminal context

Issues Fixed

• Fixes Bug: Web Terminal & Styles fail to load due to strict CSP (WASM/data: URI blocked) #9420 - CSP blocking WASM/data: URI
• Fixes Opencode Web: Terminal not working #7578 - Terminal not working (input goes to chat)
• Fixes Aggressive Input Auto-focus prevents scrolling and interacting with Terminal #9023 - Aggressive auto-focus prevents terminal interaction
• Fixes ghostty: cant rename tab #7116 - Can't rename ghostty tab
• Fixes Bug: Desktop embedded terminal freezes when shell exits via Ctrl+D or exit command #6004 - Terminal freezes on shell exit (partially - server-side fix was in fix(app): terminal no longer hangs on exit or ctrl + D and closes the pane #9506)

Files Changed

• packages/app/src/components/session/session-sortable-terminal-tab.tsx - Rename functionality
• packages/app/src/components/terminal.tsx - Simplified WebSocket close handling
• packages/app/src/context/terminal.tsx - Added error field, improved close() logic, navigation
• packages/app/src/pages/session.tsx - Terminal focus effect, error UI, disabled chat autofocus
• packages/opencode/src/pty/index.ts - Added OPENCODE_TERMINAL=1 env var
• packages/opencode/src/server/server.ts - Updated CSP for WASM

Testing

Tested manually with bun dev for both backend and frontend.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found 2 potentially related PRs that address similar issues:

1. PR fix(server): allow WASM loading in CSP for ghostty-web terminal #9451 - fix(server): allow WASM loading in CSP for ghostty-web terminal

   • fix(server): allow WASM loading in CSP for ghostty-web terminal #9451
   • Related: This PR addresses the CSP WASM issue mentioned in your PR, specifically allowing WASM loading for ghostty. Your PR fix(app): terminal improvements - focus, rename, error state, CSP #9700 appears to be a more comprehensive update that includes this CSP fix along with terminal focus and rename features.

2. PR fix(app): load ghostty wasm via asset url #9186 - fix(app): load ghostty wasm via asset url

   • fix(app): load ghostty wasm via asset url #9186
   • Related: Also addresses ghostty WASM loading, which is part of the CSP improvements in your PR.

These appear to be related to the CSP/WASM aspect of your PR. Check if these have already been merged or are still open, as your PR might supersede or complement them.

[adamdotdevin]

@unitythemaker could you share some gifs/screenshots?

[unitythemaker]

@unitythemaker could you share some gifs/screenshots?

https://screen.studio/share/bauCVmIa?private-access=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzaGFyZWFibGVMaW5rSWQiOiI1MTZlZTI3Yi01NTQ3LTRlNzItYjkyMC00Y2ZkMzZkYWJkODEiLCJpYXQiOjE3Njg5ODA4MjV9.P7STev340GstsstHo3sktGxy4dL8pJ_uA7HcFuYYnLQ

Is this helpful?

Edit: I recorded again.

[adamdotdevin]

@unitythemaker please rebase and resolve conflicts and I'll get this merged!

[unitythemaker]

@unitythemaker please rebase and resolve conflicts and I'll get this merged!

Sure!

[unitythemaker]

Conflicts resolved!