fix: flicker when adding a new note #19919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
When adding a new note when there were 3 fields, there was an awkward flicker on the screen
Fixes
Approach
When adding a note, the note type does not update,
This means we can avoid recreating the fields, which stops the keyboard being closed and opened.
One this was fixed, there was an separate visual issue:
If the current field had text, this caused two 'selection changed' visual updates, which was distracting.
So I added & used an extension to handle this
How Has This Been Tested?
Pixel 9 Pro, Android 16
There are a few flaky tests, I /think/ these are generally flaky, and I'll need to look into them
Checklist