🐛 Add close button to responsive menu sidebar #40446
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a close button (×) inside the
amp-sidebarcomponent in the responsive menu example to improve user experience. Previously, users could only close the sidebar by clicking the hamburger button again, which wasn't intuitive. Now there's a dedicated, clearly visible close button inside the sidebar.Changes
amp-sidebarelementon="tap:sidebar.close"to close the sidebarTesting
http://localhost:8000/examples/responsive-menu.amp.htmlScreenshots