Skip to content

Conversation

@bart1
Copy link
Collaborator

@bart1 bart1 commented Oct 14, 2025

Given #139 i thought it would be good to add tests locally where we compare the attributes of a pvol to the meta data of get_weather_radars. There is no need to always run it so it was designed to run only locally.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.94%. Comparing base (1392aea) to head (14ea415).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   91.92%   91.94%   +0.02%     
==========================================
  Files          25       25              
  Lines        1882     1888       +6     
==========================================
+ Hits         1730     1736       +6     
  Misses        152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bart1
Copy link
Collaborator Author

bart1 commented Oct 14, 2025

@peterdesmet & @PietrH I just discovered the release_bullets function it might be also useful for other packages you have: https://usethis.r-lib.org/reference/use_release_issue.html#customization
Have not tested it but I think this will add reminders next time I create a release issue

@bart1
Copy link
Collaborator Author

bart1 commented Nov 6, 2025

Currently the local test fail for the use for height this will be resolved with this issue: adokter/vol2birdR#144


test_that("Check Germany", {
skip_on_cran()
skip_on_ci()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip on CI?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i remember the tests can take quite long, if we want to test on CI i think we should avoid doing it on all runners (also to reduce load). These tests are mainly meant to check the data format of the radars so are not likely os dependent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well, I was just curious. Seems like it should do the trick!

I've once read, I believe in the HTTP testing guide, about setting up a Github Workflow that ran every week instead of every PR to test for this kind of integrity. But I've never actually set something like that up for any of my repo's. I've used postman instead for checking that sort of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants