STM32:Use ClockTree helper for STM32F3 #869
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .SPI1 => current_clock.p2_clk, | ||
| .SPI2, .SPI3 => current_clock.p1_clk, | ||
| // TODO: Patch for ClockTree | ||
| fn usart1Selection(src: anytype) USART1SW { |
There was a problem hiding this comment.
Please change to usart1_selection, in MicroZig we use snake case for function names.
| if (comptime std.mem.eql(u8, microzig.config.chip_name, "STM32L476VG")) { | ||
| board.init(); | ||
| } else { | ||
| board.init(&board.rcc_medium_speed) catch @panic("Board init fail"); |
There was a problem hiding this comment.
why don't you just have each board have its own speed configuration? Does this example need a specific speed? I don't like the examples having this chip stuff hardcoded.
#830 will have this function be called automatically, so we can't do this.
Maybe we can expose some option that has board.init select which config to use?
There was a problem hiding this comment.
Yeap option could be a good choice.
There was a problem hiding this comment.
For clock speed I was thinking that this could be a user choice depending on the usage. (low power mode...) The idea is to be able to have comptime value for each ClockTree and that could be used for each peripheral at comptime too for different config computation.
| if (std.mem.eql(u8, "TIMINGR", field.name)) { | ||
| break :blk field.type; | ||
| } | ||
| } else @panic("No TIMINGR register"); |
There was a problem hiding this comment.
this should be a compileError.
mathk
force-pushed
the
stm32F303-clocktree
branch
from
ba9e5e4 to
b1266cd
Compare
github-actions
bot
dismissed
their stale review
Updating with new lint results
| /// In the future we can switch on chip name to address | ||
| /// this limitation. | ||
| const microzig = @import("microzig"); | ||
| const Clock_Device = microzig.drivers.base.Clock_Device; |
There was a problem hiding this comment.
Suggestion: Rename Clock_Device to ClockDevice, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.
| .SPI1 => current_clock.p2_clk, | ||
| .SPI2, .SPI3 => current_clock.p1_clk, | ||
| // TODO: Patch for ClockTree | ||
| fn usart1Selection(src: anytype) USART1SW { |
There was a problem hiding this comment.
Please change to usart1_selection, in MicroZig we use snake case for function names.
| } else { | ||
| FLASH.ACR.modify(.{ .LATENCY = .WS2, .PRFTBE = 1 }); | ||
| // TODO: Patch for ClockTree | ||
| fn usart2Selection(src: anytype) USARTSW { |
There was a problem hiding this comment.
Please change to usart2_selection, in MicroZig we use snake case for function names.
| } | ||
|
|
||
| // TODO: Patch for ClockTree | ||
| fn usart3Selection(src: anytype) USARTSW { |
There was a problem hiding this comment.
Please change to usart3_selection, in MicroZig we use snake case for function names.
| } | ||
|
|
||
| // TODO: Patch for ClockTree | ||
| fn uart4Selection(src: anytype) USARTSW { |
There was a problem hiding this comment.
Please change to uart4_selection, in MicroZig we use snake case for function names.
| .RCC_UART4CLKSOURCE_PCLK1 => .PCLK1, | ||
| }; | ||
| } // TODO: Patch for ClockTree | ||
| fn uart5Selection(src: anytype) USARTSW { |
There was a problem hiding this comment.
Please change to uart5_selection, in MicroZig we use snake case for function names.
| } | ||
|
|
||
| // TODO: Patch for ClockTree | ||
| fn i2sSelection(src: anytype) ISSRC { |
There was a problem hiding this comment.
Please change to i2s_selection, in MicroZig we use snake case for function names.
2 participants
No description provided.