Skip to content

Link mimalloc with --as-needed on Linux #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschuff merged 2 commits into from
Jan 16, 2026
+8 −4
Merged

Link mimalloc with --as-needed on Linux #8211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c71d2df
Link mimalloc with --as-needed on Linux
dschuff Jan 15, 2026
5b75f78
setup rpath for libbinaryen
dschuff Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,9 +478,10 @@ else()
add_link_flag("-Bsymbolic")
endif()
endif()
target_link_libraries(binaryen Threads::Threads)
target_link_libraries(binaryen PUBLIC Threads::Threads)
binaryen_setup_rpath(binaryen)
if(BUILD_LLVM_DWARF)
target_link_libraries(binaryen llvm_dwarf)
target_link_libraries(binaryen PRIVATE llvm_dwarf)
endif()

if(BUILD_MIMALLOC)
Expand All @@ -489,9 +490,12 @@ if(BUILD_MIMALLOC)
endif()
message(STATUS "Building with mimalloc allocator.")
if(BUILD_STATIC_LIB)
target_link_libraries(binaryen mimalloc-static)
target_link_libraries(binaryen PRIVATE "-Wl,--push-state,--as-needed")
target_link_libraries(binaryen PRIVATE mimalloc-static)
target_link_libraries(binaryen PRIVATE "-Wl,--pop-state")
else()
target_link_libraries(binaryen mimalloc)
target_link_options(mimalloc PRIVATE "-Wl,--as-needed")
target_link_libraries(binaryen PRIVATE mimalloc)
endif()
endif()

Expand Down
Loading