Skip to content

Fix mpm depth handling #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjy5 merged 2 commits into from
Jan 1, 2026
Merged

Fix mpm depth handling #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
101fda3
Fix mpm depth convertion
kjy5 Jan 1, 2026
bcac096
Version bump
kjy5 Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ephys_link/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2.2.1"
__version__ = "2.2.2"
3 changes: 2 additions & 1 deletion src/ephys_link/bindings/mpm_binding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ async def set_depth(self, manipulator_id: str, depth: float, speed: float) -> fl
# Keep track of the previous depth to check if the manipulator stopped advancing unexpectedly.
current_depth = (await self.get_position(manipulator_id)).w
previous_depth = current_depth
depth = self.get_dimensions().w - depth
unchanged_counter = 0

# Send move request.
Expand Down Expand Up @@ -244,7 +245,7 @@ async def set_depth(self, manipulator_id: str, depth: float, speed: float) -> fl
self._movement_stopped = False

# Return the final depth.
return float((await self.get_position(manipulator_id)).w)
return float(self.get_dimensions().w - (await self.get_position(manipulator_id)).w)

@override
async def stop(self, manipulator_id: str) -> None:
Expand Down