project review #634
Open
project review #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCSharpAcademy
requested changes
Jan 12, 2026
Owner
TheCSharpAcademy
left a comment
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@kaylubr Thanks for the submission! Your project is looking good but at the moment it doesn't meet this requirement:
mathGame.kaylubr/Program.cs
Outdated
| return [num1, num2]; | ||
| } | ||
|
|
||
| public static string ValidateAnswer(string result) |
Owner
There was a problem hiding this comment.
Input Validation shouldn't be handled with exceptions. Wrong inputs/answers are not exceptions 😆. Better to handle this with a loop. I'll let you investigate how to achieve this.
mathGame.kaylubr/Program.cs
Outdated
|
|
||
| public class Program | ||
| { | ||
| static List<dynamic> history = []; |
Owner
There was a problem hiding this comment.
This isn't a requirement, but the earliest you learn this the better. One of C#'s main strengths is that it's type strong. I recommend you create a custom type instead of using dynamic. Then your collection would be something like List history = new();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.