defer to neo for extractor requirements #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing the extra_requirements so that neo manages them fully, making use of neo's extras_require structure [here](https://github.com/NeuralEnsemble/python-neo/blob/070eb47325839b8daf30299085f3b8f62eefc243/setup.py#L17)
Member
|
When NeuralEnsemble/python-neo#1163 is merge you can also merge this. |
samuelgarcia
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer to neo for format-specific requirements. Instead of specifying the ced requires sonpy, say it requires neo[ced] and let neo specify sonpy. The advantage of this is that you will always be up-to-date with the requirements of neo. If a library is added or removed for a format this will be automatically reflected in spikeinterface. I am also working with neo to make sure that it provides the appropriate hooks for this:
NeuralEnsemble/python-neo#1154