[Feature] Include Request ID at the footer of shopify theme * command errors
#6736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3585 tests passing in 1421 suites. Report generated by 🧪jest coverage report action from ed373ec |
karreiro
approved these changes
Jan 6, 2026
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you for this PR, @fredericoo! Neat approach :) LGTM and works as expected too:
I've added @EvilGenius13 because he has more context around @shopify/cli-kit/node/metadata, but I believe cmd_all_last_graphql_request_id is the way to go :)
Thanks again for this PR!
EvilGenius13
approved these changes
Jan 6, 2026
Contributor
EvilGenius13
left a comment
EvilGenius13
left a comment
There was a problem hiding this comment.
Looks good! cmd_all_last_graphql_request_id is definitely what we want in this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This will improve our relationship with the community, as we frequently need to deal with the back and forth of asking for the --verbose output.
Fixes https://github.com/Shopify/developer-tools-team/issues/467
WHAT is this pull request doing?
We make use of the
catchmethod inCommandto append the graphql request id made if present. It only affectsThemeCommandand leaves other parts of the cli untouched.How to test your changes?
Besides running the written unit tests, you may:
pnpm shopify theme pull --store <VALID_STORE_ID>.myshopify.com --theme 999999999for an error with a request idpnpm shopify theme list --store fake-store-that-does-not-exist.myshopify.comfor an error without a request id (it fails during auth)Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist