-
Notifications
You must be signed in to change notification settings - Fork 3
Rotation velocity and velocity dispersion additions #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running on L200m6 crashed for half light radii (difference was 0.13% instead of less than 0.1%)
Still need to think of how to handle different angular momentum vectors.
Testing pending.
Tests to be done
|
Managed to run the new functions successfully on an example from COLIBRE box, but it only has 15 stellar particles. I will test on a bigger box. Also, I get negative rotation velocities for some of the bands, which is something I will also look into it. |
We do not do so when computing the angular momentum vector, so this change makes it consistent with our choice to not re-centre.
Including the case for when we do luminosity-weighting. This reflects the same choice we made when computing luminosity-weighted angular momenta.
|
The latest changes make consistent choices about velocity/position centering across angular momentum and cylindrical coordinate calculation (including mass-weighted). After these changes, I no longer get a negative velocity for the example I was investigating (it went from a rotational velocity of |
|
I have been using this branch for L200m6 and L400m7 without crashes. Also for the L25 Mpc volumes across different resolutions. |
robjmcgibbon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the inconsistent reference positions and velocities. Can you please update the descriptions of the properties that changed? Then good to merge!
This PR will add rotation velocity calculations for subhalo aperture properties, as we may not want to use all bound stellar particles. Additionally, I will add luminosity-weighted averages for rotation velocities and velocity dispersions.
TODO: