Feat/ci release

[STRRL]

No description provided.

[mesa-dot-dev]

Mesa Description

TL;DR

Implemented CI/CD pipeline for releases.

What changed?

File summaries are not available.

^{Description generated by Mesa. Update settings}

[mesa-dot-dev]

Performed full review of b74980f...2c4a82e

Analysis

1. Platform Compatibility Issues - The update-homebrew.sh script uses BSD sed syntax (sed -i '') that won't work on Linux environments, creating a critical cross-platform limitation for CI/CD integration.

2. External Repository Coupling - The script contains hardcoded values for the Homebrew tap repository (STRRL/homebrew-collective), branch name ('master'), and cask paths, creating fragility if external repository structure changes.

3. Missing Authentication Handling - The implementation assumes Git authentication is pre-configured but lacks validation or helpful error messages when authentication fails, which will cause silent failures in production.

4. Conflicting Error Handling Approaches - The update-homebrew.sh script uses set -e for strict error termination while build-and-release.sh uses graceful degradation, creating inconsistent failure handling across the pipeline.

5. Non-Atomic Operations - Between cloning the tap repository and pushing updates, there's a window where concurrent releases could conflict without proper locking or conflict resolution mechanisms.

Tip

Help

Slash Commands:

• /review - Request a full code review
• /review latest - Review only changes since the last review
• /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
• /help - Get help with Mesa commands and configuration options

^{6 files reviewed | 5 comments | Edit Agent Settings • Read Docs}

[mesa-dot-dev]

This push operation will fail without proper Git authentication (SSH keys or credential helper). Additionally, the hardcoded 'master' branch may not exist in the target repository (many have migrated to 'main').

Consider:

1. Detecting the default branch dynamically:

DEFAULT_BRANCH=$(git remote show origin | grep 'HEAD branch' | cut -d' ' -f5)
git push origin "$DEFAULT_BRANCH"

2. Adding authentication validation before attempting the push
3. Providing a clear error message if push fails due to authentication
   _{Agent: 🧠 Logic}

[mesa-dot-dev]

The sed -i '' syntax is BSD sed (macOS-specific) and will fail on Linux systems. Since this script may run in CI/CD environments (suggested by .github/workflows/claude.yml), it should be cross-platform.

Consider detecting the OS and adjusting the sed syntax:

if [[ "$OSTYPE" == "darwin"* ]]; then
    sed -i '' "s/version \".*\"/version \"$VERSION\"/" "$CASK_FILE"
    sed -i '' "s/sha256 \".*\"/sha256 \"$SHA256\"/" "$CASK_FILE"
else
    sed -i "s/version \".*\"/version \"$VERSION\"/" "$CASK_FILE"
    sed -i "s/sha256 \".*\"/sha256 \"$SHA256\"/" "$CASK_FILE"
fi

_{Agent: 🧠 Logic}

[mesa-dot-dev]

The set -e conflicts with error handling in build-and-release.sh (lines 100-107). When any command fails, the script exits immediately, preventing proper error context from being passed back to the caller. This makes debugging difficult when something fails mid-execution (e.g., after cloning but before pushing).

Consider either:

1. Removing set -e and adding explicit error checking with descriptive messages
2. Using set -eE with an error trap that logs context before exiting
   _{Agent: 🧠 Logic}

[mesa-dot-dev]

The script assumes it's run from the repository root. If called from a different directory, the DMG path resolution will fail.

Make the path resolution robust:

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
PROJECT_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
DMG_PATH="$PROJECT_ROOT/build/bin/$DMG_NAME"

_{Agent: 🧠 Logic}

[mesa-dot-dev]

Missing validation for SHA256 calculation. If shasum fails or the DMG is corrupted, the variable could be empty or invalid, leading to an invalid Homebrew cask.

Add validation:

SHA256=$(shasum -a 256 "$DMG_PATH" | awk '{print $1}')
if [[ -z "$SHA256" || ${#SHA256} -ne 64 ]]; then
    echo "Error: Failed to calculate valid SHA256 hash"
    exit 1
fi

_{Agent: 🧠 Logic}