fix(alsa): hybrid enumeration and direction detection #1081
+185
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roderickvd
force-pushed
the
fix/alsa-card-enumeration
branch
from
10aa237 to
c4d9996
Compare
Combines ALSA hints with physical card probing to ensure all hardware devices are enumerated, even when hints don't list them. - Add hybrid enumeration: hints (virtual/configured) + physical probing - Add direction detection from hint metadata and physical hardware - Add Default implementation for Device - Remove unused StreamType enum Fixes #1079
roderickvd
force-pushed
the
fix/alsa-card-enumeration
branch
from
c4d9996 to
e2f8abf
Compare
roderickvd
force-pushed
the
fix/alsa-card-enumeration
branch
from
e2f8abf to
2ad6603
Compare
calwe
approved these changes
Dec 29, 2025
calwe
left a comment
calwe
left a comment
There was a problem hiding this comment.
While I obviously don't feel qualified to give a technical review in this code base, these changes do in fact work for me - and correctly show both the virtual devices from hints, and now the same hardware devices that would appear in 0.16. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes device enumeration on systems where ALSA hints don't include physical devices.
DeviceDirection::Input/Output/Duplex/Unknownbased on hint metadata and hardware capabilities (previously all devices reportedNone)Defaultimplementation that returns the ALSA "default" deviceFixes #1079