Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jan 27, 2026

Reverts #11004

@mrubens mrubens requested review from cte and jr as code owners January 27, 2026 15:30
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 27, 2026
@mrubens mrubens merged commit dc5e765 into main Jan 27, 2026
10 checks passed
@mrubens mrubens deleted the revert-11004-revert-10979-feature/ext-629-enable-parallel-tool-calling-with-new_task-isolation branch January 27, 2026 15:31
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 27, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 27, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 27, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

This PR re-enables parallel tool calling with proper safeguards for new_task isolation. The implementation correctly:

  • Enforces that tools appearing after new_task in parallel calls are truncated with error results
  • Saves the assistant message to API history before tool execution to maintain correct message ordering
  • Includes comprehensive test coverage for the isolation enforcement logic

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants