Skip to content

Add marketing site deployment quality gate rules #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 1 commit into from
Closed

Add marketing site deployment quality gate rules #10950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .roo/rules/rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,27 @@
- Use Tailwind CSS classes instead of inline style objects for new markup
- VSCode CSS variables must be added to webview-ui/src/index.css before using them in Tailwind classes
- Example: `<div className="text-md text-vscode-descriptionForeground mb-2" />` instead of style objects

4. Marketing Site (web-roo-code) Deployment Quality Gates:

- The marketing site deployment workflows (`.github/workflows/website-deploy.yml`, `.github/workflows/website-preview.yml`) must include quality checks before deploying to Vercel
- When modifying these workflows, ensure the following checks run before deployment:
- Linting: `pnpm --filter @roo-code/web-roo-code lint`
- Type checking: `pnpm --filter @roo-code/web-roo-code check-types`
- Build validation: `pnpm --filter @roo-code/web-roo-code build`
- Deployment workflows should either:
- Add a `needs:` dependency on the `code-qa` workflow (for PR-based deployments), OR
- Include a dedicated `quality-checks` job that runs before the `deploy`/`preview` jobs
- For PR-based preview deployments (`website-preview.yml`):
- The quality checks job should be a required status check in GitHub branch protection
- This prevents merging PRs with broken previews or failed quality checks
- Ensures reviewers only see working previews
- Deployment concurrency controls:
- Add `concurrency` group to prevent multiple deployments from running simultaneously
- Set `cancel-in-progress: true` to cancel older deployments when new ones start
- Prevents race conditions where older commits could overwrite newer deployments
- Vercel CLI version stability:
- Use `vercel@latest` instead of `vercel@canary` for stable, production deployments
- Canary releases are unstable and could introduce breaking changes unexpectedly
- Pin to specific versions for critical production workflows when possible
- Never deploy broken code to production - quality gates prevent deployment of code that fails linting, type-checking, or build steps
Loading