fix: Make left and right arrow keys only navigate within the current block/comment #9531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
reviewed
Dec 18, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! Had a few comments, one of which is specifically looking for some clarity.
Collaborator
|
Also, the keyboard nav tests look to be real failures but that's unsurprising since this is a bit change in left/right navigation. |
BenHenning
approved these changes
Dec 24, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko. This LGTM!
gonfunko
merged commit 909c294
into
add-screen-reader-support-experimental
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR updates the behavior of the left and right arrow keys to only navigate within the current block/workspace comment, rather than traversing through the entire workspace. This is in response to feedback from screen reader user testing. Up and down may still be used to navigate from block to block and across stacks.