-
-
Notifications
You must be signed in to change notification settings - Fork 8
2.0.0 release #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 release #44
Conversation
📝 WalkthroughWalkthroughThis pull request adjusts several configurations and documentation settings. The CI workflow matrix is modified by removing one MediaWiki version entry and altering PHP versions for specific releases. The documentation is updated with new platform requirements and release notes, while the extension dependency now requires a higher MediaWiki version. Additionally, a coding standards file is updated to exclude a particular rule from being enforced. Changes
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/ci.yml (1)
21-26: CI Matrix PHP Version Adjustments
The PHP version for theREL1_40environment has been changed to 7.4 and forREL1_41to 8.1. Verify that these changes match your extension’s compatibility matrix with the corresponding MediaWiki releases and that the test environment reflects this decision. Consider adding inline comments or documentation for the rationale behind these adjustments to aid future maintainability.phpcs.xml (1)
8-10: Exclusion of Unsorted Use Statements Rule
The coding standards configuration now explicitly excludes the "MediaWiki.Classes.UnsortedUseStatements.UnsortedUse" rule by converting the self-closing tag into an open/close block with an<exclude>element. This change is acceptable if the flexibility of use statement ordering is intentional, but please ensure that this decision is documented in your coding standards guidelines.README.md (1)
25-28: Updated Platform Requirements
The platform requirements now state "* [MediaWiki] 1.40 or later*", which is consistent with the new extension dependency. The bullet for "[Wikibase Repository]" remains without a version, likely indicating flexible compatibility. Please confirm if omitting a version constraint for Wikibase Repository is intentional or if a specific version should be specified.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci.yml(1 hunks)README.md(2 hunks)extension.json(1 hunks)phpcs.xml(1 hunks)
🔇 Additional comments (2)
extension.json (1)
18-20: MediaWiki Dependency Version Update
The MediaWiki version requirement has been updated to ">= 1.40.0", which aligns with the updated compatibility and documentation. Please ensure that all downstream integrations and developer/test environments support MediaWiki 1.40 and above.README.md (1)
82-89: New Release Notes for Version 2.0.0
The addition of the release notes section for version 2.0.0 is clear and informative. It details the updated minimum MediaWiki version and the expanded support for MediaWiki versions 1.41, 1.42, 1.43, and the development version of 1.44, as well as noting translation updates. Please double-check that these notes are in full sync with the changes inextension.jsonand the CI configuration to avoid any inconsistencies across documentation.
Summary by CodeRabbit