Skip to content

Conversation

@JeroenDeDauw
Copy link
Member

@JeroenDeDauw JeroenDeDauw commented Mar 30, 2025

Summary by CodeRabbit

  • Documentation
    • Updated platform requirements to support MediaWiki 1.40 or later.
    • Added detailed release notes for version 2.0.0, including the release date (March 30, 2025) and expanded compatibility with newer MediaWiki versions.

@coderabbitai
Copy link

coderabbitai bot commented Mar 30, 2025

📝 Walkthrough

Walkthrough

This pull request adjusts several configurations and documentation settings. The CI workflow matrix is modified by removing one MediaWiki version entry and altering PHP versions for specific releases. The documentation is updated with new platform requirements and release notes, while the extension dependency now requires a higher MediaWiki version. Additionally, a coding standards file is updated to exclude a particular rule from being enforced.

Changes

File(s) Change Summary
.github/workflows/ci.yml Removed mw: 'REL1_39'; updated PHP versions: changed REL1_40 from 8.1 to 7.4 and REL1_41 from 8.2 to 8.1.
README.md, extension.json README: Raised minimum MediaWiki version from 1.39 to 1.40, removed Wikibase Repository requirement, and added release notes for v2.0.0 (released March 30, 2025) with additional version support.
extension.json: Updated MediaWiki dependency from ">= 1.39.0" to ">= 1.40.0".
phpcs.xml Converted a self-closing rule tag to an opening/closing tag with a nested <exclude name="MediaWiki.Classes.UnsortedUseStatements.UnsortedUse" /> to exclude the rule for unsorted use statements.

Suggested reviewers

  • malberts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
.github/workflows/ci.yml (1)

21-26: CI Matrix PHP Version Adjustments
The PHP version for the REL1_40 environment has been changed to 7.4 and for REL1_41 to 8.1. Verify that these changes match your extension’s compatibility matrix with the corresponding MediaWiki releases and that the test environment reflects this decision. Consider adding inline comments or documentation for the rationale behind these adjustments to aid future maintainability.

phpcs.xml (1)

8-10: Exclusion of Unsorted Use Statements Rule
The coding standards configuration now explicitly excludes the "MediaWiki.Classes.UnsortedUseStatements.UnsortedUse" rule by converting the self-closing tag into an open/close block with an <exclude> element. This change is acceptable if the flexibility of use statement ordering is intentional, but please ensure that this decision is documented in your coding standards guidelines.

README.md (1)

25-28: Updated Platform Requirements
The platform requirements now state "* [MediaWiki] 1.40 or later*", which is consistent with the new extension dependency. The bullet for "[Wikibase Repository]" remains without a version, likely indicating flexible compatibility. Please confirm if omitting a version constraint for Wikibase Repository is intentional or if a specific version should be specified.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 581280d and 00e07fc.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml (1 hunks)
  • README.md (2 hunks)
  • extension.json (1 hunks)
  • phpcs.xml (1 hunks)
🔇 Additional comments (2)
extension.json (1)

18-20: MediaWiki Dependency Version Update
The MediaWiki version requirement has been updated to ">= 1.40.0", which aligns with the updated compatibility and documentation. Please ensure that all downstream integrations and developer/test environments support MediaWiki 1.40 and above.

README.md (1)

82-89: New Release Notes for Version 2.0.0
The addition of the release notes section for version 2.0.0 is clear and informative. It details the updated minimum MediaWiki version and the expanded support for MediaWiki versions 1.41, 1.42, 1.43, and the development version of 1.44, as well as noting translation updates. Please double-check that these notes are in full sync with the changes in extension.json and the CI configuration to avoid any inconsistencies across documentation.

@JeroenDeDauw JeroenDeDauw merged commit 028bd82 into master Mar 30, 2025
15 checks passed
@JeroenDeDauw JeroenDeDauw deleted the rel200 branch March 30, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants