Skip to content

better use is and not == #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haarcuba merged 1 commit into from
Dec 19, 2024
Merged

better use is and not == #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ Remember the [Zen of Python](https://en.wikipedia.org/wiki/Zen_of_Python): expli
However, don't do this:
```python
path = pathlib.Path('/path/to/myfile')
if path.is_dir() == True:
if path.is_dir() is True:
# do directory stuff
...
```
Expand All @@ -767,11 +767,11 @@ These sorts of "query" functions, such as `is_dir` already imply Boolean values.
This is true even if the functions name does not contain "is", e.g. (in fact, there is a considerable body of opinion that believes that "is is evil", and even more importantly - we agree!)
```python
# bad! overly explicit, non-English code
if person.underage() == True:
if person.underage() is True:
raise NoAlcoholForYouError()

# bad! this is truly evil
if person.is_underage() == True:
if person.is_underage() is True:
raise NoAlcoholForYouError()

# good :) English like code
Expand Down