Apply per-target warhead effects on ReceiveDamage

[TaranDahl]

Toggle per-target warhead effects apply timing

• Now you can set the following flag to false to apply the Phobos warhead effects that take effect on each target when taking damage, rather than when the projectiles detonate.
  • This will allow such effects to be applied through damage without projectiles, including but not limited to damage from particles, vanilla radiation, and Ares' GenericWarhead superweapon.
  • This will also cause all effects that can completely prevent damage to also prevent these warhead effects, including but not limited to DamageSelf, DamageAirThreshold, AffectsAllies, AffectsAir.
  • If you use a warhead with CellSpread to damage a building multiple times, then these effects will be applied multiple times. If you don't want this to happen, use MergeBuildingDamage.
  • The affected effects include:
    • Remove mind-control
    • Type convertion
    • BuildingSell & BuildingUndeploy
    • RemoveDisguise
    • ReverseEngineer
    • Modify shield
    • Modify attach-effects
    • Critical hits
      • Due to technical reasons, Crit.SuppressWhenIntercepted=false and Crit.ApplyChancePerTarget=true will forced to be used.

In rulesmd.ini:

[CombatDamage]                        ; WarheadType
ApplyPerTargetEffectsOnDetonate=true  ; boolean

[SOMEWARHEAD]                         ; WarheadType
ApplyPerTargetEffectsOnDetonate=      ; boolean, default to [CombatDamage] -> ApplyPerTargetEffectsOnDetonate

- Ares' warhead effects, such as EMP or IronCurtain warhead, will not be affected. 
- Ares' warhead effect controllers, such as `EffectsRequireDamage`, only affect Ares' effects. So they have nothing to do with this.

[github-actions]

Nightly build for this pull request:

• compiled-dll-e7749aabb216221d314901ee2694a006018221d8.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Starkku]

Code and documentation are fine.

I assume with ApplyPerTargetEffectsOnDetonate=false the Warhead effects require non-zero damage to be forwarded to receive damage function. Ares added a key called EffectsRequireDamage to remove this requirement for its damage-adjacent Warhead effects, does that still function in this case too? Something maybe worth mentioning in doc if so.

[TaranDahl]

Code and documentation are fine.

I assume with ApplyPerTargetEffectsOnDetonate=false the Warhead effects require non-zero damage to be forwarded to receive damage function. Ares added a key called EffectsRequireDamage to remove this requirement for its damage-adjacent Warhead effects, does that still function in this case too? Something maybe worth mentioning in doc if so.

I don't think it should have an impact. Because this change only affects the Phobos-related effects, and Ares effects still use its own area search.