Skip to content

Add Default Item Quality Value option into Options #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateokladaric wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add Default Item Quality Value option into Options #1662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
165732e
add default item quality option in settings
mateokladaric Dec 19, 2025
50b1c4c
speedy changes
mateokladaric Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Classes/Item.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ function ItemClass:NormaliseQuality()
if not self.quality then
self.quality = 0
elseif not self.uniqueID and not self.corrupted and not self.mirrored and not (self.base.type == "Charm") and self.quality < self.base.quality then -- charms cannot be modified by quality currency.
self.quality = self.base.quality
self.quality = main.defaultItemQuality
end
end
end
Expand Down
12 changes: 12 additions & 0 deletions src/Modules/Main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ function main:Init()
self.thousandsSeparator = ","
self.decimalSeparator = "."
self.defaultItemAffixQuality = 0.5
self.defaultItemQuality = 20
self.showTitlebarName = true
self.dpiScaleOverridePercent = GetDPIScaleOverridePercent and GetDPIScaleOverridePercent() or 0
self.showWarnings = true
Expand Down Expand Up @@ -623,6 +624,9 @@ function main:LoadSettings(ignoreBuild)
if node.attrib.defaultGemQuality then
self.defaultGemQuality = m_min(tonumber(node.attrib.defaultGemQuality) or 0, 23)
end
if node.attrib.defaultItemQuality then
self.defaultItemQuality = m_min(tonumber(node.attrib.defaultItemQuality) or 0, 20)
end
if node.attrib.defaultCharLevel then
self.defaultCharLevel = m_min(m_max(tonumber(node.attrib.defaultCharLevel) or 1, 1), 100)
end
Expand Down Expand Up @@ -783,6 +787,7 @@ function main:SaveSettings()
betaTest = tostring(self.betaTest),
edgeSearchHighlight = tostring(self.edgeSearchHighlight),
defaultGemQuality = tostring(self.defaultGemQuality or 0),
defaultItemQuality = tostring(self.defaultItemQuality or 20),
defaultCharLevel = tostring(self.defaultCharLevel or 1),
defaultItemAffixQuality = tostring(self.defaultItemAffixQuality or 0.5),
lastExportWebsite = self.lastExportWebsite,
Expand Down Expand Up @@ -1042,6 +1047,13 @@ function main:OpenOptionsPopup()
controls.defaultGemQuality.tooltipText = "Set the default quality that can be overwritten by build-related quality settings in the skill panel."
controls.defaultGemQualityLabel = new("LabelControl", { "RIGHT", controls.defaultGemQuality, "LEFT" }, { defaultLabelSpacingPx, 0, 0, 16 }, "^7Default gem quality:")

nextRow()
controls.defaultItemQuality = new("EditControl", { "TOPLEFT", nil, "TOPLEFT" }, { defaultLabelPlacementX, currentY, 80, 20 }, self.defaultItemQuality, nil, "%D", 2, function(itemQuality)
self.defaultItemQuality = m_min(tonumber(itemQuality) or 0, 20)
end)
controls.defaultItemQuality.tooltipText = "Set the default quality that will be applied to newly created or pasted items."
controls.defaultItemQualityLabel = new("LabelControl", { "RIGHT", controls.defaultItemQuality, "LEFT" }, { defaultLabelSpacingPx, 0, 0, 16 }, "^7Default item quality:")

nextRow()
controls.defaultCharLevel = new("EditControl", { "TOPLEFT", nil, "TOPLEFT" }, { defaultLabelPlacementX, currentY, 80, 20 }, self.defaultCharLevel, nil, "%D", 3, function(charLevel)
self.defaultCharLevel = m_min(m_max(tonumber(charLevel) or 1, 1), 100)
Expand Down