-
Notifications
You must be signed in to change notification settings - Fork 69
Bump the npm_and_yarn group across 11 directories with 1 update #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump the npm_and_yarn group across 11 directories with 1 update #4
Conversation
Bumps the npm_and_yarn group with 1 update in the /017 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /009 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /016 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /007 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /020 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /018 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /015 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /013 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /011 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /008 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Bumps the npm_and_yarn group with 1 update in the /019 directory: [webpack-dev-server](https://github.com/webpack/webpack-dev-server). Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) Updates `webpack-dev-server` from 2.11.5 to 5.2.2 - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-server/commits/v5.2.2) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: webpack-dev-server dependency-version: 5.2.2 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
| "style-loader": "^0.17.0", | ||
| "webpack": "^2.3.2", | ||
| "webpack-dev-server": "^2.4.2" | ||
| "webpack-dev-server": "^5.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The webpack-dev-server dependency is being updated to ^5.2.2, which is incompatible with the project's existing webpack version ^2.3.2, causing the development server to crash.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The pull request updates webpack-dev-server to version ^5.2.2 while leaving the core webpack dependency at ^2.3.2. According to official documentation, webpack-dev-server version 5 and higher requires webpack version 5.0.0 or greater as a peer dependency. This version mismatch will cause the development server to fail immediately upon startup when npm start is executed. The server will crash because it will attempt to use webpack v5 APIs that are not present in the installed webpack v2.3.2. This issue affects all projects updated in this PR, rendering their development environments unusable.
💡 Suggested Fix
To resolve the incompatibility, the webpack dependency should be upgraded to a version compatible with webpack-dev-server v5, such as ^5.0.0 or higher. This will likely require further changes to the webpack configuration files to account for breaking changes between webpack v2 and v5, such as replacing the deprecated CommonsChunkPlugin.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: 017/package.json#L24
Potential issue: The pull request updates `webpack-dev-server` to version `^5.2.2` while
leaving the core `webpack` dependency at `^2.3.2`. According to official documentation,
`webpack-dev-server` version 5 and higher requires `webpack` version 5.0.0 or greater as
a peer dependency. This version mismatch will cause the development server to fail
immediately upon startup when `npm start` is executed. The server will crash because it
will attempt to use webpack v5 APIs that are not present in the installed webpack
v2.3.2. This issue affects all projects updated in this PR, rendering their development
environments unusable.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8160339
Bumps the npm_and_yarn group with 1 update in the /017 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /009 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /016 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /007 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /020 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /018 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /015 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /013 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /011 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /008 directory: webpack-dev-server.
Bumps the npm_and_yarn group with 1 update in the /019 directory: webpack-dev-server.
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.
... (truncated)
Commits
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.
... (truncated)
Commits
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.
... (truncated)
Commits
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.
... (truncated)
Commits
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.
... (truncated)
Commits
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.
... (truncated)
Commits
Updates
webpack-dev-serverfrom 2.11.5 to 5.2.2Release notes
Sourced from webpack-dev-server's releases.
... (truncated)
Changelog
Sourced from webpack-dev-server's changelog.