Creating convert.mitgcm_to_sgrid #2483
Merged
+313
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
requested changes
Jan 20, 2026
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good - one nit-picky change then happy to merge.
I will look at pushing some refactorings in a future PR
VeckoTheGecko
approved these changes
Jan 20, 2026
Co-authored-by: Nick Hodgskin <36369090+VeckoTheGecko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a
convert_mitgcm_to_sgrid()method.Note that it works on the
mitgcm_UV_surface_zonally_reentrant.ncflow in the examples_download folder, but not yet on thedatasets_circulation_models["ds_MITgcm_netcdf"]Still TODO:
cftime._cftime.Datetime360Daycalendar (timedelta_to_float fails oncftime._cftime.Datetime360Daycalendars #2486)datasets_circulation_models["ds_MITgcm_netcdf"](convert.mitgcm_to_sgrid breaks on datasets_circulation_models["ds_MITgcm_netcdf"] #2484)