Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 23, 2025

After bumping Deno from alpine-2.5.6 to alpine-2.6.3, tests failed due to TypeScript type resolution issues with the assert import alias.

Changes

  • Test imports: Updated 6 test files to import directly from @std/assert instead of the assert alias

    • main.test.ts, src/commands/options.test.ts, src/commands/set.test.ts
    • src/hooks/post.test.ts, src/util/increment.test.ts, src/util/version.test.ts
  • Dependencies: Updated deno.json to ensure assert alias points to @std/assert@^1.0.14

  • Lock file: Regenerated deno.lock with compatible dependency versions

The imports changed from:

import { assertEquals } from "assert";

To:

import { assertEquals } from "@std/assert";

This resolves TypeScript type checking errors while maintaining runtime compatibility.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI and others added 2 commits December 23, 2025 15:13
Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>
Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>
Copilot AI changed the title [WIP] Update denoland/deno from alpine-2.5.6 to alpine-2.6.3 Fix test failures after Deno 2.6.3 upgrade Dec 23, 2025
Copilot AI requested a review from justinmchase December 23, 2025 15:21
@justinmchase justinmchase marked this pull request as ready for review December 23, 2025 15:30
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 23, 2025
@justinmchase justinmchase merged commit ae675ef into dependabot/docker/denoland/deno-alpine-2.6.3 Dec 23, 2025
1 of 2 checks passed
@justinmchase justinmchase deleted the copilot/sub-pr-138 branch December 23, 2025 15:31
justinmchase added a commit that referenced this pull request Dec 23, 2025
* Bump denoland/deno from alpine-2.5.6 to alpine-2.6.3

Bumps denoland/deno from alpine-2.5.6 to alpine-2.6.3.

---
updated-dependencies:
- dependency-name: denoland/deno
  dependency-version: alpine-2.6.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix test failures after Deno 2.6.3 upgrade (#139)

* Initial plan

* Plan to fix test failures after Deno 2.6.3 upgrade

Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>

* Fix test failures by updating assert imports to @std/assert

Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants