[feat]: support list all devices and show in standard json format #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances the device listing functionality by supporting both available and all devices, outputting results in standard JSON format for improved shell tool compatibility (e.g., jq).
Key changes:
- Modified
--listargument from a simple flag to accept optional values ('available' or 'all') - Wrapped
list_devices()output withjson.dumps()for standard JSON formatting - Added
available_filterparameter to control device filtering based on list mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stf_appium_client/cli.py
Outdated
|
|
||
| if args.list: | ||
| print(client.list_devices(requirements=requirement)) | ||
| print(json.dumps(client.list_devices(requirements=requirement, available_filter=(args.list!='all')))) |
There was a problem hiding this comment.
Missing spaces around the != operator. According to PEP 8 and the codebase convention, there should be spaces around comparison operators.
Suggestion: Change args.list!='all' to args.list != 'all'
Suggested change
| print(json.dumps(client.list_devices(requirements=requirement, available_filter=(args.list!='all')))) | |
| print(json.dumps(client.list_devices(requirements=requirement, available_filter=(args.list != 'all')))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output in standard JSON format so that it can be parsed with tools like jq in the shell.