Register Octo Fire Guard plugin (#1)

[rdar-lab]

Register Octo File Guard Plugin

[jneilliii]

I don't see any glaring issues with this plugin but want to get @foosel 's feedback on any additional warnings that might need to be included on the plugin listing since this kind of gives the idea of safety and might not necessarily be a guarantee (ie OctoPrint not running to monitor faulty printer).

[jacopotediosi]

Hello @rdar-lab,

I noticed that your plugin is similar to the ThermalRunaway plugin but with some additional features - good job!

I briefly reviewed your repo, and below are my suggestions:

• In your repository, the initial release has not been published. It is important to remember to publish releases, because they are the mechanism you chose to manage plugin updates (see your implementation of the function get_update_information).

• In your current code, any authenticated user can call the API command test_emergency_actions and trigger an emergency stop of prints, even without having the CONTROL Permission. I suggest adding a check to restrict usage of this API to users who have the appropriate permission (e.g., if Permissions.CONTROL.can():).

• I also noticed that in your JavaScript code you use the PNotify function several times. OctoPrint currently ships with PNotify version 3, which by default does not perform HTML encoding of notification titles and text. Although I see that you are not currently inserting untrusted data into notifications, to prevent potential XSS vulnerabilities - including in anticipation of future code changes - I recommend setting the text_escape and title_escape attributes to true in all PNotify calls, unless you explicitly need to insert HTML. Alternatively, you can use the ._escape() function from the Lodash library (already imported by OctoPrint) when concatenating data.

Additionally, next time please follow the Pull Request template, as it helps reviewers save time.

Thank you again for your contribution 😄

[rdar-lab]

@jneilliii I added a warning message about this concern
@jacopotediosi thanks for the review comments, I have fixed all of them

[rdar-lab]

• You have read the "Registering a new Plugin" guide.
• You want to and are able to maintain the plugin you are registering, long-term.
• You understand why the plugin you are registering works.
• You have read and acknowledge the Code of Conduct.

What is the name of your plugin?

Octo Fire Guard

What does your plugin do?

An OctoPrint plugin that monitors printer temperatures in real-time to prevent fire hazards. The plugin watches both hotend and heatbed temperatures and triggers emergency shutdown procedures when configurable thresholds are exceeded.

Where can we find the source code of your plugin?

https://github.com/rdar-lab/octo-fire-guard/

Was any kind of genAI (ChatGPT, Copilot etc) involved in creating this plugin?

Yes!
The plugin was created using vibe coding with Github Copilot

Is your plugin commercial in nature?

No

Does your plugin rely on some cloud services?

No

[jacopotediosi]

When compiling the page with jekyll, this warning is not rendered properly:

Likely plugins.octoprint.org currently doesn't support GitHub flavored Markdown admonition syntax (yet?).

[jacopotediosi]

Aside from my review comment above, everything else looks good to me now.