Skip to content

[FIX] Don't try to enqueue dependent jobs when job failed #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomaspaulb wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+7 −4
Open

[FIX] Don't try to enqueue dependent jobs when job failed #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions queue_job/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from ..delay import chain, group
from ..exception import FailedJobError, RetryableJobError
from ..job import ENQUEUED, Job
from ..job import DONE, ENQUEUED, Job

_logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -155,9 +155,12 @@ def retry_postpone(job, message, seconds=None):
buff.close()
raise

_logger.debug("%s enqueue depends started", job)
cls._enqueue_dependent_jobs(env, job)
_logger.debug("%s enqueue depends done", job)
if job.state == DONE:
# if not, then job.env.cr could be closed
# besides, we would not want to trigger dependent jobs anyway
_logger.debug("%s enqueue depends started", job)
cls._enqueue_dependent_jobs(env, job)
_logger.debug("%s enqueue depends done", job)

@classmethod
def _get_failure_values(cls, job, traceback_txt, orig_exception):
Expand Down