[UPD] adapt to new cronjobs, simplify branch initialization #5394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Replace No-Dot Syntax (140, 150, ...) | ||
| sed -i "s/$NODOTDOLD/$NODOTNEW/g" .github/workflows/* | ||
| sed -i "s/$NODOTPREV/$NODOTDOLD/g" .github/workflows/* | ||
| sed -i "s/$NODOTDOLD/$NODOTNEW/g" .github/workflows/{documentation-commit.yml,test-migration.yml} |
There was a problem hiding this comment.
test-migration.yml does not exist in the repository, so it raises an error (or is a problem with my environment)
Member
Author
There was a problem hiding this comment.
did you do the renaming with the commandline as pointed out above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as I propose to make OpenUpgrade behave more like a standard OCA repo, here the changes coming with this, and also I propose to rely on the cronjobs for unpleasant work.
Note that the script won't run for 18.0 because I renamed the test.yml file, if you want to test the script, add
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --tree-filter '[ -f .github/workflows/test.yml ] && mv .github/workflows/test.yml .github/workflows/test-migration.yml || true' 18.0after line 7, that's what I did