Skip to content

Conversation

@alejoe91
Copy link
Contributor

@alejoe91 alejoe91 commented Aug 29, 2022

This PR improves the checks the OpenEphysBinaryRawIO by:

  1. pre-mapping folder structure in terms of recording nodes, experiments, and recordings
  2. assigning block_index and seg_index after pre-mappping (it is possible that some experiments/recordings are deleted by the user because of errors etc.)
  3. adds checks to ensure that:
    • experiments (blocks) are consistent acrosse multiple nodes (if present)
    • streams are consistent across recordings (segments)
    • the same streams are present in all experiments (blocks)
      In case the latter check fails, there is a new option to use the argument experiment_names to select a subset of experiments with consistent streams to be loaded.

@pep8speaks
Copy link

pep8speaks commented Aug 29, 2022

Hello @alejoe91! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 335:69: W291 trailing whitespace
Line 424:65: E261 at least two spaces before inline comment
Line 429:100: E501 line too long (104 > 99 characters)
Line 433:100: E501 line too long (120 > 99 characters)
Line 457:65: E261 at least two spaces before inline comment
Line 540:100: E501 line too long (101 > 99 characters)

Comment last updated at 2022-08-31 09:06:25 UTC

@alejoe91 alejoe91 changed the title Openephys check consistency experiments (WIP) Openephys check consistency experiments Aug 29, 2022
@samuelgarcia samuelgarcia added this to the 0.11.0 milestone Aug 29, 2022
@alejoe91 alejoe91 changed the title (WIP) Openephys check consistency experiments Openephys check consistency experiments Aug 29, 2022
@alejoe91
Copy link
Contributor Author

@samuelgarcia i don't know why core tests failed! I only change one rawio file... can you check and in case retrigger?

@samuelgarcia
Copy link
Contributor

Thanks Alessio.
This is really cool.

For me this OK to be merge.

@JuliaSprenger : I don't known if you want to have a look.
We need it for the release.

@samuelgarcia samuelgarcia self-assigned this Aug 30, 2022
@samuelgarcia
Copy link
Contributor

Test fails from something unrelated (neurlynx) I re run the test to check.
Unfortunatly the entire dataset will be download again (because test did not finish...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants