Skip to content

Conversation

@apdavison
Copy link
Member

@apdavison apdavison commented Jun 2, 2022

fixes #1126

@pep8speaks
Copy link

pep8speaks commented Jun 2, 2022

Hello @apdavison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-02 16:26:13 UTC

@apdavison apdavison requested a review from JuliaSprenger June 2, 2022 16:25
@apdavison apdavison added this to the 0.11.0 milestone Jun 2, 2022
@apdavison apdavison force-pushed the irrsig-in-neomatlabio branch from 17f3fcb to 957649c Compare June 2, 2022 16:26
@apdavison apdavison linked an issue Jun 2, 2022 that may be closed by this pull request
@apdavison apdavison changed the title Add support for IrregularlySampledSignal in NeoMatlabIO (fixes #1126) Add support for IrregularlySampledSignal in NeoMatlabIO Jun 2, 2022
@JuliaSprenger
Copy link
Member

Thanks for the extension! Looks good to me :)

@JuliaSprenger JuliaSprenger merged commit ffde176 into NeuralEnsemble:master Jun 9, 2022
@apdavison apdavison deleted the irrsig-in-neomatlabio branch July 5, 2022 14:09
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for IrregularlySampledSignal to NeoMatlabIO

3 participants