[Neuralynx] add 'exclude_filename' keyword #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @JuliaSprenger! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-28 14:46:15 UTC |
Member
Author
Contributor
|
@JuliaSprenger yes, this works, behaving similarly to the master branch HEAD if the files are manually deleted. |
Contributor
|
Thank you @TheChymera for testing this. |
Member
Author
|
@samuelgarcia ready to merge. |
Contributor
|
@JuliaSprenger THere are some conflict maybe because I merge another PR in the wring order... |
JuliaSprenger
force-pushed
the
add/neuralynx_exclude_files
branch
from
3ee065b to
63c9015
Compare
Member
Author
|
@samuelgarcia I included your suggestion for the parameter handling and fixed the conflicts. Ready for the next round. |
samuelgarcia
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to exclude specific files from being read based on their base filename. See feature request #889 and #1038 (comment)