Preserve permissions #183
Merged
Preserve permissions #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhamp
approved these changes
Mar 19, 2025
PeteBishwhip
approved these changes
Mar 19, 2025
Member
PeteBishwhip
left a comment
PeteBishwhip
left a comment
There was a problem hiding this comment.
Brilliant. Thanks for your contribution and thank you for adding a test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildCommand::class'scopyresets all file perms to100644r+r for owner, read for everyone else.Fixed this by just setting it back to original with
chmod. Tests passing, added new assertions to ensure this works.There are some intricacies around the 2nd param of
chmod. It seems to be very user-unfriendly in terms of its behavior when dealing with various permission formats. Decimal values provided asintseem to be the way to go, which is also what thefilepermsfunction returns by default.Did a test build and my file permissions came out identical between the real project and the files copied to
resources/app, I think we're good.