-
Notifications
You must be signed in to change notification settings - Fork 1.6k
DOC: Fixing fundamental types codeblock #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Later in the same file demonstrating Array container for Is this expected? or those literals are removed, we might need to fix that as well |
| Array<int, kN> source; | ||
|
|
||
| NumericConverter<descltype(destination), decltype(source)> convert; | ||
| NumericArrayConverter<int8_t, int, kN> convert; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally it was a typo here (descltype) but also can't use decltype as it expands to const cutlass::NumericConverter<cutlass::Array<int8_t, 16, false>, cutlass::Array<int, 16, true>
|
|
||
| Operators are define to convert between numeric types in `numeric_conversion.h`. Conversion operators are defined in | ||
| terms of individual numeric elements and on arrays which enable the possibility of efficient hardware | ||
| support on current and future NVIDIA GPUs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the duplicate section (it exists inside Containers section) and the code block is empty as well. If this wasn't intended then we can remove this as well
|
This PR has been labeled |
cutlass/core_io.his required to use the IO overloads oncutlass::half_t