-
Notifications
You must be signed in to change notification settings - Fork 0
Added Swift Package Index links #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@NSFatalError has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
""" WalkthroughThe README file was updated to replace a single static Swift version badge with two dynamic badges linking to the Swift Package Index, showing supported Swift versions and platforms. The "Documentation & Sample Project" section now includes explicit bullet-point links to full documentation for Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
9-14: Add descriptive alt text to badge images for accessibility.The
<img>tags for the Swift Package Index badges currently lackaltattributes, which is flagged by markdownlint (MD045). Please add meaningful alt text for screen readers. For example:- <a href="https://swiftpackageindex.com/NSFatalError/Probing"> - <img src="https://img.shields.io/endpoint?url=...swift-versions" /> - </a> + <a href="https://swiftpackageindex.com/NSFatalError/Probing"> + <img src="https://img.shields.io/endpoint?url=...swift-versions" alt="Supported Swift versions on Swift Package Index" /> + </a> - <a href="https://swiftpackageindex.com/NSFatalError/Probing"> - <img src="https://img.shields.io/endpoint?url=...platforms" /> - </a> + <a href="https://swiftpackageindex.com/NSFatalError/Probing"> + <img src="https://img.shields.io/endpoint?url=...platforms" alt="Supported platforms on Swift Package Index" /> + </a>🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
10-10: Images should have alternate text (alt text)
null(MD045, no-alt-text)
13-13: Images should have alternate text (alt text)
null(MD045, no-alt-text)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
10-10: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
13-13: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build-and-test (ios)
- GitHub Check: build-and-test (watchos)
- GitHub Check: build-and-test (visionos)
- GitHub Check: build-and-test (tvos)
- GitHub Check: build-and-test (macos)
🔇 Additional comments (1)
README.md (1)
98-100: Approve updated documentation links.The new bullet-point links to full documentation for
ProbingandProbeTestingon the Swift Package Index are clear, accurate, and improve discoverability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
9-14: Add alt text to badge images for accessibility
The<img>tags for the Swift Package Index badges are missingaltattributes, which is required for accessibility (and to satisfy markdownlint MD045). Please add descriptivealttext.<a href="https://swiftpackageindex.com/NSFatalError/Probing" style="display:inline-block;"> - <img src="https://img.shields.io/endpoint?url=https%3A%2F%2Fswiftpackageindex.com%2Fapi%2Fpackages%2FNSFatalError%2FProbing%2Fbadge%3Ftype%3Dswift-versions" /> + <img src="https://img.shields.io/endpoint?url=https%3A%2F%2Fswiftpackageindex.com%2Fapi%2Fpackages%2FNSFatalError%2FProbing%2Fbadge%3Ftype%3Dswift-versions" alt="Supported Swift versions" /> </a> <a href="https://swiftpackageindex.com/NSFatalError/Probing" style="display:inline-block;"> - <img src="https://img.shields.io/endpoint?url=https%3A%2F%2Fswiftpackageindex.com%2Fapi%2Fpackages%2FNSFatalError%2FProbing%2Fbadge%3Ftype%3Dplatforms" /> + <img src="https://img.shields.io/endpoint?url=https%3A%2F%2Fswiftpackageindex.com%2Fapi%2Fpackages%2FNSFatalError%2FProbing%2Fbadge%3Ftype%3Dplatforms" alt="Supported platforms" /> </a>Optionally, for consistency, you can also add
altto the Codecov badge:<a href="https://codecov.io/gh/NSFatalError/Probing" style="display:inline-block;"> - <img src="https://codecov.io/gh/NSFatalError/Probing/graph/badge.svg?token=CDPR2O8BZO" /> + <img src="https://codecov.io/gh/NSFatalError/Probing/graph/badge.svg?token=CDPR2O8BZO" alt="Codecov coverage badge" /> </a>🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
10-10: Images should have alternate text (alt text)
null(MD045, no-alt-text)
13-13: Images should have alternate text (alt text)
null(MD045, no-alt-text)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
10-10: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
13-13: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
🔇 Additional comments (1)
README.md (1)
98-101: Documentation links look good
The bullet-point links to the fullProbingandProbeTestingdocumentation on the Swift Package Index are clear, correctly formatted, and meet the PR objective of providing explicit links.
Summary by CodeRabbit
ProbingandProbeTesting.