-
Notifications
You must be signed in to change notification settings - Fork 35
Upgrade to NHS.UK frontend v10.2 #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7b97530 to
28b0c24
Compare
28b0c24 to
7d10c37
Compare
|
Rebased with |
7d10c37 to
12fccf7
Compare
12fccf7 to
504718a
Compare
|
A potential issue in the Do List, the In the NHS service manual examples include this explicitly. The explicit role="list" ensures screen readers still identify them as lists for assistive technology users. Also worth noting: a new Task List component has been added in the latest nhsuk-frontend library, which may be worth reviewing to see if it needs implementing. |
|
Thanks @mikeathan-nhs
Thanks for flagging this. Like with #316 (comment), do you want it including? It would be great if someone could implement #68 (comment) using our NHS.UK frontend fixtures
Yeah this was missed from NHS.UK frontend v9.1.0 in previous updates to this library I'm not viewing it as a blocker for the v6.x beta releases but would be great to see it contributed |
Regarding role="list", it could be included in this PR for completeness, or addressed in a follow-up. |
|
|
The missing Ready for review again @mikeathan-nhs Thanks |
|
The work in this branch is matching the behaviour and layout as defined in the service manual and nhsuk-frontend 10.0 work. |



This PR upgrades the React components to NHS.UK frontend v10.2
Smaller (and inline) buttons are now included but I've included the upgrade guide content below too
Use the password input component to help users accessibly enter passwords
The password input component from NHS.UK frontend v10.2 allows users to choose:
This helps users use longer and more complex passwords without needing to remember what they've already typed.
Smaller versions of buttons
You can now use smaller versions of buttons by adding the
smallprop.Add inline buttons to text inputs and select menus
You can now add inline buttons to text inputs and select menus using the
formGroupProps.afterInputprop.Add a 'code' prop for text inputs that accept codes and sequences
We've added a new
codeprop for the text input component. This improves readability of text inputs that receive codes and sequences (like NHS numbers, security codes or booking references).<TextInput label="What is your NHS number?" labelProps={{ isPageHeading: true, size: 'l' }} inputMode="numeric" spellCheck="false" width="10" + code />Add a 'divider' between select options
Newer browsers support using
<hr>(horizontal rule) elements inside a<select>element to help visually break up options for better readability.We've added a new
<Select.Divider />child component for select menus to support this feature. For example:<Select> <Select.Option value="first-name-ascending">First name (A to Z)</Select.Option> <Select.Option value="first-name-descending">First name (Z to A)</Select.Option> + <Select.Divider /> <Select.Option value="last-name-ascending">Last name (A to Z)</Select.Option> <Select.Option value="last-name-descending">Last name (Z to A)</Select.Option> </Select>