Split ASMAPI into a seperate artifact #73
+196
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaintNinja
requested changes
Jan 11, 2026
| newLine = false | ||
| } | ||
|
|
||
| dependencies { |
Contributor
There was a problem hiding this comment.
Maybe the coremods-api should be added here as an api to avoid accidental breaking changes from forgetting to manually add it when updating?
Member
Author
There was a problem hiding this comment.
Not possible to do, it creates a circular dependency. If @Jonathing has an idea on how to make gradle happy, I dont know of one.
* What went wrong:
Circular dependency between the following tasks:
:classes
\--- :compileJava
\--- :coremods-api:jar
+--- :coremods-api:classes
| \--- :coremods-api:compileJava
| +--- :jar
| | +--- :classes (*)
| | \--- :compileJava (*)
| \--- :coremods-api:jar (*)
\--- :coremods-api:compileJava (*)
Co-authored-by: Paint_Ninja <PaintNinja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick pass to split ASMAPI into its own jar for use in Forge when not using JavaScript coremods.
There are 3 methods that call into the JavaScript coremoding manager,
loadFile,loadData, andlog.These methods are expected to throw exceptions if invoked from a non-JS transformer. So it should be fine.
For old versions that ship the JS engine, they will now need to ship the ASMAPI artifact as well.