Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 18, 2025

Use sha256 utility for checksumming. The utility matches the existing implementation and was upstreamed to utils.


Note

Switches snaps-utils checksumming to the shared sha256 from @metamask/utils and cleans up related dependencies/tests.

  • Update checksum to call @metamask/utils sha256; checksumFiles unchanged except for using the new helper
  • Remove conditional WebCrypto/noble logic and corresponding tests in checksum.test.ts
  • Drop @noble/hashes from package.json and yarn.lock

Written by Cursor Bugbot for commit 02cf92d. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (1fdd521) to head (02cf92d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
- Coverage   98.34%   98.34%   -0.01%     
==========================================
  Files         422      422              
  Lines       12066    12059       -7     
  Branches     1876     1872       -4     
==========================================
- Hits        11866    11859       -7     
  Misses        200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review January 5, 2026 11:38
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 5, 2026 11:38
@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit e2ebf1a Jan 5, 2026
128 checks passed
@FrederikBolding FrederikBolding deleted the fb/use-sha256-util branch January 5, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants