Add support for custom HTTP transport via URLSessionProtocol and URLSessionFactory #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official openai-go SDK (and others) supports custom HTTP client injection via option.WithHTTPClient(), enabling use cases like custom transports, proxies, and testing. This change brings the same capability to the Swift SDK. Changes: - Make URLSessionProtocol and related types public - Add public convenience init accepting customSession parameter This allows users to provide their own URLSessionProtocol implementation, similar to how openai-go allows custom http.Client injection.
sachaservan
changed the title
Expose URLSessionFactory protocol publicly to allow injecting custom session factories for streaming requests. This enables custom HTTP transport implementations to intercept streaming data. Changes: - Make URLSessionFactory, URLSessionDelegateProtocol, and URLSessionDataDelegateProtocol public - Add AnyObject constraint to delegate protocols for weak references - Update ImplicitURLSessionStreamingSessionFactory to accept custom factory - Add new OpenAI initializer with streamingURLSessionFactory parameter
sachaservan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Expose URLSessionFactory and related delegate protocols as public APIs, and add a new OpenAI initializer that accepts a custom URLSessionFactory for streaming requests.
Why
The official openai-go SDK (and others like openai-node) support custom HTTP clients via
option.WithHTTPClient(). This change brings the same capability to the Swift SDK. This change allows full control over all HTTP requests.Specifically, it allows us to provide custom URLSession implementations for streaming requests (chatsStream, etc.), enabling use cases like custom transport layers, request encryption, or specialized networking requirements.
Affected Areas