Migrate Python CLI template to uv #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Why these changes are being introduced: This is the first pass in migrating to uv from pipenv. How this addresses that need: * Removes Pipfile and Pipfile.lock * Updates pyproject.toml to be a valid uv project * All dependencies handled via 'uv add' and exist in pyproject.toml * Makefile and pre-commits updated to use uv syntax * Github actions *temporarily* hardcoded in local workflows, with a TODO to move these to a shared workflow when things settle down * Bumps python to 3.13 Side effects of this change: * Many! Hard pivot from Pipenv installation and running of the application. At this time, the largest side effect is the loss of 'pipenv run <appname>'. A future commit will apply a new strategy, but that is not present now. A workaround is 'uv run my_app/cli.py`. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1425
Why these changes are being introduced: As we continue to slowly build out this uv driven version of the CLI template, finding little things to update along the way. How this addresses that need: * Updated Dockerfile to use uv in image build * Add convenience docker methods in Makefile, unassociated with AWS ECR (helpful for local testing) * Update dependencies Side effects of this change: * None Relevant ticket(s): * None
jonavellecuerdo
force-pushed
the
IN-1425-uv
branch
from
95fceb3 to
8331067
Compare
Pull Request Test Coverage Report for Build 21072504558Details
💛 - Coveralls |
Contributor
ehanson8
reviewed
Jan 16, 2026
Contributor
ehanson8
left a comment
ehanson8
left a comment
There was a problem hiding this comment.
Looking good but a few questions and comments
|
|
||
| COPY Pipfile* / | ||
| RUN pipenv install | ||
| # Install package into system python, includes "marimo-launcher" script |
Contributor
There was a problem hiding this comment.
This docstring probably shouldn't have the marimo-launcher reference
| # Docker | ||
| #################################### | ||
| docker-build: # Build local image for testing | ||
| docker build -t python-cli-template:latest . |
Contributor
There was a problem hiding this comment.
Is there a reason this is python-cli-template rather than my-app? It would simplify the find/replace if they were the same
| # https://mitlibraries.atlassian.net/wiki/spaces/IN/pages/3432415247/Python+Project+Linters#Template-for-pyproject.toml | ||
|
|
||
| [project] | ||
| name = "python-cli-template" |
Contributor
There was a problem hiding this comment.
Again, could this be my-app?
| [project] | ||
| name = "python-cli-template" | ||
| version = "2.0.0" | ||
| requires-python = ">=3.12" |
Contributor
There was a problem hiding this comment.
I think we want ~=3.12.0 rather than >=3.12 to avoid inadvertently upgrading to 3.13, ~=3.12.0 keeps it in 3.12 but gets the newest patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Migrate Python CLI template to uv
How can a reviewer manually see the effects of these changes?
The
uv-based GitHub CI workflow has been tested in MITLibraries/timdex-embeddings#33Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review