fix: Remove hjson and rely on json only #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: pin LPF to 0.1.3
chore(master): release 3.1.8
Member
|
Think it's good now, thanks @RoyThomsonMonash! |
lachlangrose
reviewed
Jul 9, 2024
lachlangrose
reviewed
Jul 9, 2024
lachlangrose
reviewed
Jul 9, 2024
tests/thickness/InterpolatedStructure/test_interpolated_structure.py
Outdated
Show resolved
Hide resolved
lachlangrose
reviewed
Jul 9, 2024
lachlangrose
requested changes
Jul 9, 2024
Member
lachlangrose
left a comment
lachlangrose
left a comment
There was a problem hiding this comment.
A few things to change in my comments but other than that go for it
Member
|
@lachlangrose thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the hjson dependency as the JSON files used are simple enough without Loop having to build and maintain the hjson library in the loop3d channel. Note this is for merging into v3.2 not the current version.
Also note that the current CI/CD tests are failing due to LoopProjectFile having multiple thicknesses but both master and v3.2 branches in map2loop do not have them yet. Should we pin LoopProjectFile to v0.1.3 until multiple thicknesses are merged or just merge in multiple thicknesses soon?
Also there is a separate linting issue in one of the tests causing linting to fail.
Fixes #64