Diet addition with no end date

[kollil]

New diet to bypass the enddate is added to the meds order list

E-X1380 - Diet Daily (Non-standard), 5LOP (TAD)

[Ohsudev]

I’m not seeing a review button. Raymond From: Lakshmi Kolli ***@***.***> Sent: Tuesday, May 27, 2025 2:08 PM To: LabKey/onprcEHRModules ***@***.***> Cc: Raymond Blasa ***@***.***>; Review requested ***@***.***> Subject: [EXTERNAL] Re: [LabKey/onprcEHRModules] Diet addition with no end date (PR #1355) @kollil<https://urldefense.com/v3/__https:/github.com/kollil__;!!Mi0JBg!KT9IsTHmxyFzhpz4VQmCAEZe-WG_mQs-Tkakb18R5aXLz1dLZ3et-azjfcNxqnLJhdiUVaS3-kb3b559iAibpGU$> requested your review on: #1355<https://urldefense.com/v3/__https:/github.com/LabKey/onprcEHRModules/pull/1355__;!!Mi0JBg!KT9IsTHmxyFzhpz4VQmCAEZe-WG_mQs-Tkakb18R5aXLz1dLZ3et-azjfcNxqnLJhdiUVaS3-kb3b559nMN9fpg$> Diet addition with no end date. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/LabKey/onprcEHRModules/pull/1355*event-17838399739__;Iw!!Mi0JBg!KT9IsTHmxyFzhpz4VQmCAEZe-WG_mQs-Tkakb18R5aXLz1dLZ3et-azjfcNxqnLJhdiUVaS3-kb3b559X9nQoZ8$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ASHU2YHFX2LWJXF72JBUUQL3ATHZPAVCNFSM6AAAAAB5EENHXKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXHAZTQMZZHE3TGOI__;!!Mi0JBg!KT9IsTHmxyFzhpz4VQmCAEZe-WG_mQs-Tkakb18R5aXLz1dLZ3et-azjfcNxqnLJhdiUVaS3-kb3b5598MVVUGY$>. You are receiving this because your review was requested.Message ID: ***@***.***>

[kollil]

Hi @labkey-martyp,
I am getting teamcity build error which is unrelated to my changes in the code. Could you please look into this so I can merge the code into the master.

Thanks
Lakshmi

[labkey-martyp]

Hi @labkey-martyp, I am getting teamcity build error which is unrelated to my changes in the code. Could you please look into this so I can merge the code into the master.

Thanks Lakshmi

Hi @kollil, since you updated the treatment_orders end date trigger to be an error, the tests need to fill in end date when entering treatment orders. Looks like just one test is testing that area. I believe those rows in the test are auto populated from a template, so you'll have to make the test manually enter an end date for each row. Here is where you would do that. Try adding that and let me know if you run into issues.

[kollil]

Hi @labkey-martyp,
I have added a line in the test code and now it's complaining another dataset. Please see the attached screenshot of the code.

Thanks

Lakshmi

[labkey-martyp]

Hi @labkey-martyp, I have added a line in the test code and now it's complaining another dataset. Please see the attached screenshot of the code.

Thanks Lakshmi

[labkey-martyp]

Hi @kollil, the line you added is only asserting that the end date exists, it is not adding it to the row. Since the test is loading from a template that does not have an end date the test will have to manually add the end date. You can see above in the same test how the drugGrid is getting the code manually added.

Note that it looks like there are three treatment orders being added so each row will need an end date.