Skip to content

Issues #734 and #457: update message and spacing #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-susanh merged 8 commits into from
Dec 30, 2025
Merged

Issues #734 and #457: update message and spacing #1911

labkey-susanh merged 8 commits into from
Dec 30, 2025

Conversation

@labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Dec 24, 2025 •
edited
Loading

Rationale

  • GitHub Issue 734: Reduce reason text input width on smaller screens
  • GitHub Issue 457: Update messaging for deleting samples linked to studies

Related Pull Requests

Changes

  • Update deleteErrorMessage to act as a resolver of error messaging
  • Update min-width setting for reason text input to work better on smaller media

@labkey-susanh labkey-susanh requested review from XingY and cnathe and removed request for cnathe December 29, 2025 18:31
@labkey-susanh labkey-susanh merged commit 1e3d315 into develop Dec 30, 2025
3 checks passed
@labkey-susanh labkey-susanh deleted the fb_smallFixes261seh branch December 30, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XingY XingY XingY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-susanh @XingY