Live Cancellation Interface #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglepuff
requested changes
Dec 18, 2025
Collaborator
naglepuff
left a comment
naglepuff
left a comment
There was a problem hiding this comment.
Looks good!
My one thought is that maybe we should use 143 as the exit code for cancelled jobs. My understanding is that the convention is to use 128 + N, where N is the signal number. Since the code that kills the child processes uses SIGTERM, it would be 128 + 15.
I also think we should move this value into a constant somewhere, even if we keep -1.
Collaborator
Author
|
I missed the constant message and merged too quick. |
naglepuff
added a commit
that referenced
this pull request
Dec 19, 2025
* Add cancel job command to IPC service * Add button to cancel in-flight jobs * Add ability to remove jobs from queue * Add UI for un-queueing jobs * Live Cancellation Interface (#1561) * live cancellation of jobs * set exit code for cancelled jobs to 143 * add const cancelledJobExitCode --------- Co-authored-by: Bryon Lewis <61746913+BryonLewis@users.noreply.github.com> Co-authored-by: Bryon Lewis <Bryon.Lewis@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is a small PR that would make it so live cancellation (clicking the Cancel button in the Job History) will work and will log that the job has been cancelled in the dive_job_manifest.json as well as the runlog.txt.
The main goal of this PR is to provide users with feedback and information that a job was cancelled.
DIVE-20251217-JobCancellation_small.mp4
DesktopJoba new propertycancelledJobthat can be set when a job is cancelledJobobject to the IPCMain function instead of just the jobId. This was done so I could use thejob.tstoupdateHistoryand add to the runlog a cancellation message as well as settingcancelledJobupdateHistoryis modified so that if thecancelledJobis set it will stop other updates that may be happeningjob.tsnow listens for acancel-jobevent that can be set in the IPCMain handler to set a job to cancelledutils.tsfunction to write thedive_job_manifest.jsonand therunlog.txtto indicate that a job was cancelled. This will be useful if we start reading in the folder the JobHistory and displaying it.JobHistory.vuekey is modified to that it ensures that when thecancelledJoborexitCodeare updated it will update the page and display it.